feat: add BIP353 DNS payment instructions#236
Open
sdmg15 wants to merge 2 commits intobitcoindevkit:masterfrom
Open
feat: add BIP353 DNS payment instructions#236sdmg15 wants to merge 2 commits intobitcoindevkit:masterfrom
sdmg15 wants to merge 2 commits intobitcoindevkit:masterfrom
Conversation
sdmg15
force-pushed
the
feat/bip353-payment-instructions
branch
from
ba3c713 to
a0f3e9d
Compare
…ating a transaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for BIP353 payment instructions.
The following notable changes are done:
resolve_dns_recipientwhich receives a Human Readable Name (HRN) and returns the associated addresscreate_txfor it to support user specifying recipients asHRN.Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md